From 4e03a1f31abe1b23c42d193a1121adc61e05a850 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roman=20Jaro=C5=A1?= <hello@romanjaros.dev>
Date: Wed, 21 Aug 2024 12:33:41 +0200
Subject: [PATCH] Fix retail translation frame when Quest has Model preview

---
 Quests/Quests.lua | 28 ++++------------------------
 Quests/Utils.lua  | 24 ++++++++++++++++++++++++
 sync.sh           |  5 ++---
 3 files changed, 30 insertions(+), 27 deletions(-)

diff --git a/Quests/Quests.lua b/Quests/Quests.lua
index 9b633a7..58264da 100755
--- a/Quests/Quests.lua
+++ b/Quests/Quests.lua
@@ -97,24 +97,14 @@ function CzechQuestsAddon:ShowQuestTranslation(event)
         if QuestMapDetailsScrollFrame:IsShown() then
             -- get quest ID
             local questId = C_QuestLog.GetSelectedQuest()
-
             -- detect if quest frame does not include npc preview
-            local hasObjective = false;
-            if C_QuestLog.GetQuestObjectives then
-                local objectives = C_QuestLog.GetQuestObjectives(questId)
-                if objectives then
-                    for _, __ in ipairs(objectives) do
-                        hasObjective = true;
-                    end
-                end
-            end
-
+            local hasModel = QuestModelScene:IsShown()
             -- show translation frame
             local questData = CzechQuestsAddon:GetData("quest", questId)
             if questData then
                 local suffix = CzechQuestsAddon.options.DEBUG_MODE and " (" .. questId .. ")" or ""
                 local questTitle = questData.title .. suffix
-                local xOffset = hasObjective and 210 or 0
+                local xOffset = hasModel and 210 or 0
                 CzechQuestsAddon:ShowTranslationFrame(
                     questTitle,
                     questData.objective,
@@ -135,18 +125,8 @@ function CzechQuestsAddon:ShowQuestTranslation(event)
     if QuestFrame:IsShown() then
         -- get quest ID
         local questId = GetQuestID()
-
         -- detect if quest frame does not include npc preview
-        local hasObjective = false;
-        if C_QuestLog.GetQuestObjectives then
-            local objectives = C_QuestLog.GetQuestObjectives(questId)
-            if objectives then
-                for _, __ in ipairs(objectives) do
-                    hasObjective = true;
-                end
-            end
-        end
-
+        local hasModel = QuestModelScene and QuestModelScene:IsShown() or false
         -- show translation frame
         if questId then
             local questData = CzechQuestsAddon:GetData("quest", questId)
@@ -154,7 +134,7 @@ function CzechQuestsAddon:ShowQuestTranslation(event)
                 CzechQuestsAddon.translationFrame:Show()
                 local suffix = CzechQuestsAddon.options.DEBUG_MODE and " (" .. questId .. ")" or ""
                 local questTitle = questData.title .. suffix
-                local xOffset = hasObjective and 210 or 0
+                local xOffset = hasModel and 210 or 0
                 if event == "QUEST_PROGRESS" then
                     CzechQuestsAddon:ShowTranslationFrame(
                         questTitle,
diff --git a/Quests/Utils.lua b/Quests/Utils.lua
index d25d4b9..707c495 100755
--- a/Quests/Utils.lua
+++ b/Quests/Utils.lua
@@ -79,4 +79,28 @@ function CzechQuestsAddon:replacePlaceholders(text)
     formatted = string.gsub(formatted, '<rP3>', race.p3);
 
     return formatted
+end
+
+function CzechQuestsAddon:dumpTable(tbl, indent)
+    -- Initialize indent if not provided
+    indent = indent or 0
+
+    -- Check if the input is actually a table
+    if type(tbl) ~= "table" then
+        print(string.rep("  ", indent) .. tostring(tbl))
+        return
+    end
+
+    -- Iterate through the table and print keys and values
+    for k, v in pairs(tbl) do
+        local formatting = string.rep("  ", indent) .. tostring(k) .. ": "
+        if type(v) == "table" then
+            print(formatting)
+            CzechQuestsAddon:dumpTable(v, indent + 1)
+        elseif type(v) == "boolean" then
+            print(formatting .. (v and "true" or "false"))
+        else
+            print(formatting .. tostring(v))
+        end
+    end
 end
\ No newline at end of file
diff --git a/sync.sh b/sync.sh
index 0ba5954..8d74958 100644
--- a/sync.sh
+++ b/sync.sh
@@ -3,8 +3,8 @@
 src_folder="."
 
 # RETAIL
-wow_folder="beta"
-#wow_folder="classic_era"
+#wow_folder="beta"
+wow_folder="classic_era"
 
 # CLASSIC ERA
 dest_folder="/Applications/World of Warcraft/_${wow_folder}_/Interface/AddOns/CzechQuests"
@@ -14,4 +14,3 @@ fswatch -o "$src_folder" | while read -r change; do
   rsync -au --delete "$src_folder/Quests/Data/$wow_folder/" "$dest_folder/Quests/Data/"
   cp "$src_folder/Quests/Data/other.lua" "$dest_folder/Quests/Data/"
 done
-